Add missing fields to AWS::Serverless::Function::ScheduleEvent and remove version from required in IAMPolicyDocument
Issue #, if available: Related issue in aws-toolkit-vscode: https://github.com/aws/aws-toolkit-vscode/issues/2765
Description of changes: This PR adds the missing fields for ScheduleEvent and also removes version from required fields in IAMPolicyDocument. I can't find anywhere that explicitly says it must be required
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Merging #477 (1731c44) into master (35a4b24) will decrease coverage by
0.10%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #477 +/- ##
=========================================
- Coverage 6.35% 6.25% -0.11%
=========================================
Files 30 30
Lines 15582 15582
=========================================
- Hits 991 974 -17
- Misses 14570 14586 +16
- Partials 21 22 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| intrinsics/conditions.go | 60.46% <0.00%> (-39.54%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 61b50d2...1731c44. Read the comment docs.
~~Unfortunately, this is not easy to fix (see my PR where testes are failing). I will need some extra time to think about how to integrate this PR.~~
sorry, commented on the wrong PR
Thank you for this! I've merged my PR since I couldn't change the commit message from yours.