generative-ai-cdk-constructs icon indicating copy to clipboard operation
generative-ai-cdk-constructs copied to clipboard

feat(construct): merged amazon aurora vector stores

Open maxtybar opened this issue 1 year ago • 1 comments

Fixes #373

  1. Merged AmazonAuroraDefaultVectorStore into AmazonAuroraVectorStore resulting in a single construct that customer needs to import.
  2. Created fromExistingAuroraVectorStore in AmazonAuroraVectorStore construct so customers could import values from an existing Aurora database.
  3. Refactored models and moved it outside of bedrock construct in a dedicated foudnationsmodels construct. This results in elimination of potential cross-reference issues in the future where a knowledge base vector is consuming models but is also being referenced within bedrock construct.
  4. Fix an issue where aurora cannot be deployed from Mac

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

maxtybar avatar May 02 '24 16:05 maxtybar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.37%. Comparing base (8a81eb2) to head (207e39b). Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   93.03%   93.37%   +0.34%     
==========================================
  Files          47       47              
  Lines       11183    11338     +155     
  Branches      359      364       +5     
==========================================
+ Hits        10404    10587     +183     
+ Misses        779      751      -28     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 16:05 codecov[bot]

What's blocking the release of this? I want to get started with this construct library, but don't want to deal with fixing breaking changes later, and after #346 (thanks, 🎉) was patiently waiting for this one too to finally get my hands dirty. 😁

moltar avatar May 25 '24 12:05 moltar

This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

github-actions[bot] avatar Jun 09 '24 01:06 github-actions[bot]

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

github-actions[bot] avatar Jun 12 '24 01:06 github-actions[bot]