aws-solutions-constructs icon indicating copy to clipboard operation
aws-solutions-constructs copied to clipboard

aws-apigateway-dynamodb enable passing of methodOptions for use in addProxyMethodToApiResource

Open kevohagan opened this issue 2 years ago • 1 comments

The addProxyMethodToApiResource accepts a params.methodOptions to be able to override/complement the default options defined

https://github.com/awslabs/aws-solutions-constructs/blob/dc48e482f936c856398c7e600a7805a99a3bea44/source/patterns/%40aws-solutions-constructs/core/lib/apigateway-helper.ts#L324

unfortunately the aws-apigateway-dynamodb construct does not pass this in its call the the addProxyMethodToApiResource method e.g

https://github.com/awslabs/aws-solutions-constructs/blob/dc48e482f936c856398c7e600a7805a99a3bea44/source/patterns/%40aws-solutions-constructs/aws-apigateway-dynamodb/lib/index.ts#L265

Use Case

Overriding default headers to specify CORS values would be a great use case to do it whilst overriding the default method responses.

Proposed Solution

Be able to pass in methodOptions as aditional opitional attribute . e.g : createIntegrationMethodOptions

  • [ ] :wave: I may be able to implement this feature request
  • [ ] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

kevohagan avatar Feb 20 '23 14:02 kevohagan

Thanks, we'll take a look.

biffgaut avatar Feb 21 '23 18:02 biffgaut