aws-solutions-constructs icon indicating copy to clipboard operation
aws-solutions-constructs copied to clipboard
verified publisher icon awslabs

curious about the CWAlerm threshold for kinesis.

Open watany-dev opened this issue 3 years ago • 4 comments

https://github.com/awslabs/aws-solutions-constructs/blob/5124e47a6d3bf2cd4196148041b51cbc7b8aebe2/source/patterns/%40aws-solutions-constructs/core/lib/kinesis-streams-helper.ts#L66

Question about this place. The threshold is 2592000, but isn't what this number represents 30 days to the second? I didn't understand it when I actually made it. I believe the 12 hours in the comment refers to 43,200 seconds!

Reproduction Steps

cdk deploy

Error Log

no.

Environment

  • CDK CLI Version :2.20
  • CDK Framework Version:2.20
  • AWS Solutions Constructs Version :2.05
  • OS :Amazonlinux2
  • Language :Typescript

This is :bug: Bug Report

watany-dev avatar Apr 10 '22 04:04 watany-dev

This certainly looks like an error. We'll discuss it as a team and look at addressing it. Thanks.

biffgaut avatar Apr 10 '22 16:04 biffgaut

Fixed in PR #667, will be released in 1.153.0 and 2.6.0

biffgaut avatar Apr 22 '22 19:04 biffgaut

Asking for clarity here, isn't the metric in Milliseconds, not seconds? (GetRecords.IteratorAgeMilliseconds)

Not sure how the original threshold number was arrived at, but as it stands it seems like the threshold should be increased by 10^3

Benjscho avatar Sep 20 '22 23:09 Benjscho

It sure looks like you are correct - we'll look a little closer and update accordingly unless other info comes to light. Thanks.

biffgaut avatar Sep 21 '22 12:09 biffgaut