awslabs
feat(aws-apigateway-sqs): update construct to allow custom path params
…for GET, POST, DELETE operations on the SQS
- Issue #665
- Description: Add 3 new optional parameters to ApiGatewayToSqsProps With those the user can change the endpoints for GET, POST, DELETE message of the SQS
I've read that one concern was backwards compatibility This solution should backwards compatible, because if the properties are not set, the fallback will be the previous behaviour.
Small PSA: this is my first Open Source PR, so bear with me please. I'm open to any suggestions/requests to learn how to do a propper OpenSource PR.
AWS CodeBuild CI Report
- CodeBuild project: githubautobuild-for-cdk-v2
- Commit ID: bbffe2f29c7ecca346c4f8181eef46b8828b2530
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
AWS CodeBuild CI Report
- CodeBuild project: githubautobuild-for-cdk-v2
- Commit ID: 91fbeea9890271d0e5636f411fa599006e740271
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
AWS CodeBuild CI Report
- CodeBuild project: githubautobuild-for-cdk-v2
- Commit ID: ecff909447a00d5b752025be42cd524d6952a086
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thanks for the contribution - we're excited to review it, but won't be able to until Thursday morning.
Thanks for the contribution - we're excited to review it, but won't be able to until Thursday morning.
Thanks for the heads up. Cheers :)
Small PSA: this is my first Open Source PR, so bear with me please. I'm open to any suggestions/requests to learn how to do a propper OpenSource PR.
You did just fine. Some issues did pop up in review that you will read about, but the issues were surprises to us as well.