prompt_toolkit 2

[carlwgeorge]

I'm working on updating the prompt_toolkit package in Fedora to version 2, which is required to update ipython to version 7. However, some packages, including aws-shell, still require prompt_toolkit 1. What is the status of this project migrating to prompt_toolkit 2?

https://python-prompt-toolkit.readthedocs.io/en/stable/pages/upgrading.html

[joguSD]

In the long term we would like to migrate this project to use PTK2, but don't currently have any plans in the short term to do this.

[asyschikov]

Please reconsider migrating to PTK2, right now because of this it is impossible to keep aws-shell and ipython in the same environment due to PTK version clash. I may be able to help you with that if you are accepting contributions.

[Currerius]

Please reconsider migrating to PTK2, right now because of this it is impossible to keep aws-shell and ipython in the same environment due to PTK version clash. I may be able to help you with that if you are accepting contributions.

I second this point! jupyter notebook is pretty much standard for Python DS and the excellent aws-shell should not conflict with it.

[aldegoeij]

quite some rework as prompt-toolkit<2.0.0 is not backward compatible: https://python-prompt-toolkit.readthedocs.io/en/stable/pages/upgrading.html

************* Module awsshell.style
E: 16, 0: No name 'default_style_extensions' in module 'prompt_toolkit.styles' (no-name-in-module)
E: 16, 0: No name 'style_from_dict' in module 'prompt_toolkit.styles' (no-name-in-module)
************* Module awsshell.ui
E:  2, 0: No name 'to_cli_filter' in module 'prompt_toolkit.filters' (no-name-in-module)
E:  6, 0: No name 'TokenListControl' in module 'prompt_toolkit.layout.controls' (no-name-in-module)
E:  6, 0: No name 'FillControl' in module 'prompt_toolkit.layout.controls' (no-name-in-module)
E: 14, 0: No name 'prompt' in module 'prompt_toolkit.layout' (no-name-in-module)
E: 14, 0: Unable to import 'prompt_toolkit.layout.prompt' (import-error)
E: 16, 0: No name 'toolbars' in module 'prompt_toolkit.layout' (no-name-in-module)
E: 16, 0: Unable to import 'prompt_toolkit.layout.toolbars' (import-error)
E: 18, 0: No name 'explode_tokens' in module 'prompt_toolkit.layout.utils' (no-name-in-module)
E: 19, 0: No name 'lexers' in module 'prompt_toolkit.layout' (no-name-in-module)
E: 19, 0: Unable to import 'prompt_toolkit.layout.lexers' (import-error)
E: 95,63: bad operand type for unary ~: is_done (invalid-unary-operand-type)
E:114,19: bad operand type for unary ~: is_done (invalid-unary-operand-type)
E:131,43: bad operand type for unary ~: is_done (invalid-unary-operand-type)
E:152,16: Unexpected keyword argument 'get_height' in constructor call (unexpected-keyword-arg)
E:183,16: Unexpected keyword argument 'buffer_name' in constructor call (unexpected-keyword-arg)
E:188,43: bad operand type for unary ~: is_done (invalid-unary-operand-type)
************* Module awsshell.keys
E: 13, 0: No name 'manager' in module 'prompt_toolkit.key_binding' (no-name-in-module)
E: 13, 0: Unable to import 'prompt_toolkit.key_binding.manager' (import-error)
************* Module awsshell.app
E: 13, 0: No name 'create_eventloop' in module 'prompt_toolkit.shortcuts' (no-name-in-module)
E: 16, 0: No name 'interface' in module 'prompt_toolkit' (no-name-in-module)
E: 16, 0: Unable to import 'prompt_toolkit.interface' (import-error)
E: 17, 0: No name 'interface' in module 'prompt_toolkit' (no-name-in-module)
E: 17, 0: Unable to import 'prompt_toolkit.interface' (import-error)
E:313,24: Instance of 'InMemoryHistory' has no 'append' member (no-member)
E:347,15: Unexpected keyword argument 'accept_action' in constructor call (unexpected-keyword-arg)

[kapilkd13]

Is there any update on this. Its more than a year and I still can't use ipython and aws-shell in same env.

[NBrendel]

any news regarding this? it's impossible not to have both iPython & aws-shell

[alanzchen]

Any update?

[Ismael-VC]

Better target PTK3 as it's what is used now in (almost) 2022.