aws-sdk-rust icon indicating copy to clipboard operation
aws-sdk-rust copied to clipboard

Generated crates suggest to use deprecated `aws_config::load_from_env`

Open mchoicpe-amazon opened this issue 1 year ago • 1 comments
trafficstars

Describe the issue

https://docs.rs/aws-sdk-appconfigdata/latest/aws_sdk_appconfigdata/client/index.html

Suggests the following:

let config = aws_config::load_from_env().await;
let client = aws_sdk_appconfigdata::Client::new(&config);

Not sure if this was intentional, but load_from_env is deprecated by default (behavior-version-latest disabled by default). The documentation should change to suggest construction like so:

let config = aws_config::load_from_env().await;
let client = aws_sdk_appconfigdata::Client::new(&config);

Alternative the doc could inform users the feature flag is required to make the example work.

Links

https://docs.rs/aws-sdk-appconfigdata/latest/aws_sdk_appconfigdata/client/index.html https://docs.rs/aws-config/1.1.7/aws_config/fn.load_from_env.html

mchoicpe-amazon avatar Mar 04 '24 18:03 mchoicpe-amazon

Thanks for filing this. I think we just need to switch it over to calling load_defaults with BehaviorVersion::latest() instead.

jdisanti avatar Mar 07 '24 22:03 jdisanti