aws-sdk-kotlin icon indicating copy to clipboard operation
aws-sdk-kotlin copied to clipboard

Support renamed errors in aws-json-1.1 protocol

Open everett1992 opened this issue 2 years ago • 1 comments

Describe the feature

Smithy recently allowed renaming error shapes but added a validator to prevent renamed errors with aws protocols.

Most aws protocols only use shape name in error serialization, which is why error renames were originally banned. However, aws json 1.0 uses qualified shape id and can support renamed errors.

The protocol should match errors based on the original (not renamed) fully qualified shape id.

Once all smithy sdk's (rust, js, go, kotlin) confirm that aws json 1.0 supports renamed errors smithy can remove the protocol from the validator and allow renames.

https://github.com/awslabs/smithy/issues/1545

Is your Feature Request related to a problem?

I have smithy a smithy model with shapes with conflicting names, tho the qualified shape id is unique. I'd like to use aws json 1.0 protocol, which could support renamed error shapes, but the validator throws an error.

Proposed Solution

No response

Describe alternative solutions or features you've considered

No response

Acknowledge

  • [ ] I may be able to implement this feature request

AWS Kotlin SDK version used

N/A

Platform (JVM/JS/Native)

N/A

Operating System and version

N/A

everett1992 avatar Jan 05 '23 00:01 everett1992

Thanks for the feature request, @everett1992. We'd like to support this feature of aws-json-1.1 but, since no published AWS service models use this, we won't be prioritizing this immediately. I'll leave this open as a tracking issue and provide an update when we begin/complete the work.

ianbotsf avatar Jan 06 '23 16:01 ianbotsf