aws-sdk-kotlin icon indicating copy to clipboard operation
aws-sdk-kotlin copied to clipboard

fix: merge per-op custom metadata to avoid clobbering per-client metadata

Open ianbotsf opened this issue 3 years ago • 2 comments

Issue #

Closes #694

Description of changes

Our existing UserAgent middleware clobbers any per-client custom metadata that may have been detected from JVM system properties or environment variables. This change merges the two to avoid loss.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ianbotsf avatar Sep 02 '22 20:09 ianbotsf

A new generated diff is ready to view: https://github.com/awslabs/aws-sdk-kotlin/compare/__generated-main...__generated-fix-user-agent-merging

github-actions[bot] avatar Sep 02 '22 20:09 github-actions[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 09 '22 15:09 sonarqubecloud[bot]

A new generated diff is ready to view: https://github.com/awslabs/aws-sdk-kotlin/compare/__generated-main...__generated-fix-user-agent-merging

github-actions[bot] avatar Sep 09 '22 15:09 github-actions[bot]