aws-sdk-kotlin icon indicating copy to clipboard operation
aws-sdk-kotlin copied to clipboard

Generate Presigners that sign the querystring rather than headers

Open kggilmer opened this issue 3 years ago • 1 comments

Presigned URLs are easier to work with than presigned requests, because of the extra complexity of serializing/deserializing lists of lists (headers). vs just a URL as a string.

Currently the SDK generates most presigners to use headers.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment

Describe the Feature

Is your Feature Request related to a problem?

Proposed Solution

Describe alternatives you've considered

Additional Context

  • [ ] I may be able to implement this feature request

kggilmer avatar Oct 29 '21 01:10 kggilmer

Truth table for valid presigned operations of supported services using querystring rather than headers:

Service: S3 signedBodyValue: UNSIGNED-PAYLOAD hasBody: false location: QUERY_STRING (getobject) (GET)
Service: S3 signedBodyValue: UNSIGNED-PAYLOAD hasBody: false location: QUERY_STRING (putobject) (PUT)
Service: STS signedBodyValue: null hasBody: true location: QUERY_STRING (GET)
Service: Polly signedBodyValue: null hasBody: true location: QUERY_STRING (GET)

kggilmer avatar Oct 29 '21 01:10 kggilmer

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Dec 01 '22 17:12 github-actions[bot]

We'll handle this in smithy-kotlin#755.

ianbotsf avatar Dec 01 '22 17:12 ianbotsf