aws-sdk-kotlin icon indicating copy to clipboard operation
aws-sdk-kotlin copied to clipboard

Published 20 hours ago • verified publisher icon awslabs

optimize file based streams

Open aajtodd opened this issue 4 years ago • 1 comments

It's not particularly efficient to have to launch a coroutine and proxy an SdkByteReadChannel to CRT. We should probably consider special casing file inputs such that we don't have to cross the JNI boundary for signing and uploading content.

See https://github.com/awslabs/aws-crt-java/issues/308 which blocks this. We would also need a way to get at the file through HttpBody, see https://github.com/awslabs/smithy-kotlin/issues/297 for some ideas.

aajtodd avatar Jul 07 '21 14:07 aajtodd

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to provide a comment or open a new issue.

github-actions[bot] avatar Jul 08 '22 15:07 github-actions[bot]

We've significantly refactored the I/O model as well as implemented signing directly in Kotlin since this issue was opened. Closing as there is no signs this is actually any kind of bottleneck, we can always re-evaluate with concrete use cases/issues if that isn't the case.

aajtodd avatar Sep 13 '23 14:09 aajtodd

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Sep 13 '23 14:09 github-actions[bot]