Handle Clock Skew

[kggilmer]

Some of the AWS SDK's (Java/C# for sure) handle local clock skew differences which can affect signing.

Something to keep in mind and look into. CRT may or may not already handle this IDK.

Some more context: https://aws.amazon.com/blogs/developer/clock-skew-correction/

internal id: 173288088

[kggilmer]

Verified w/ CRT team that there is nothing in CRT that currently would handle this for us.

[kggilmer]

Java implementation: https://github.com/aws/aws-sdk-java-v2/blob/master/core/sdk-core/src/main/java/software/amazon/awssdk/core/retry/ClockSkew.java

[kggilmer]

4 year old open customer request to add clock skew to BOTO3: https://github.com/boto/boto3/issues/1252

[aajtodd]

There was a recent issue in Amplify (or rather one of the lower level libs aws-sdk-android or aws-sdk-ios) regarding clock skew.

[kggilmer]

Hmm, as in there as a problem with the SDK implementation? Or that iOS doesn't have the feature? (from searching it looks like both v1 and v2 java sdks have a clock skew feature)

[kggilmer]

Spoke with people on java and .net teams regarding the perceived importance of the feature. Neither felt it was important to provide at GA.

[aajtodd]

Spoke with people on java and .net teams regarding the perceived importance of the feature. Neither felt it was important to provide at GA.

Tend to agree, I don't think we have this slotted before then. Was just mentioning I saw an issue recently related to it, wasn't implying we should bump it up or anything.

[kggilmer]

@normj's take:

I suspect the feature is a bit overkill now a days. The idea is client machines running the SDK might not be as strict with the time settings as servers so we added it. In reality who doesn't have their client machine's time automatically set from the internet. I think you are fine holding off till you get customer feedback asking for the feature.

There is also the small use case of when an AWS host for a service has a messed up time setting that we have compensated for that. I think that has happen once with S3 that I know of. But this is a small use case.

[github-actions[bot]]

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to provide a comment or open a new issue.

[github-actions[bot]]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.