aws-sdk-kotlin icon indicating copy to clipboard operation
aws-sdk-kotlin copied to clipboard

Consider returning service-generated requestId in all response types, not just errors

Open kggilmer opened this issue 4 years ago • 2 comments

The Ruby v2 SDK does this, and they say this is to help customers debug problems that may not be related to service exceptions.

Acceptance criterea:

  • determine if anything in our architeture would prevent this / other compat concerns
  • get some customer or SDK team data about if this is something we should add to our SDK
  • provide a design

kggilmer avatar Mar 30 '21 20:03 kggilmer

I think this is something we should do FWIW.

Java V2 does as well. All responses inherit from AwsResponse (they also generate a base class response type for the service).

     java.lang.Object
        software.amazon.awssdk.core.SdkResponse
            software.amazon.awssdk.awscore.AwsResponse
                software.amazon.awssdk.services.lambda.model.LambdaResponse
                    software.amazon.awssdk.services.lambda.model.AddPermissionResponse 

AwsResponse contains a field AwsResponseMetadata

aajtodd avatar Apr 05 '21 16:04 aajtodd

Also there is a WIP design doc that touches on this

aajtodd avatar Apr 29 '21 14:04 aajtodd

This information will be made available through inceptors eventually, not directly in response types.

ianbotsf avatar Dec 01 '22 16:12 ianbotsf

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Dec 01 '22 16:12 github-actions[bot]