aws-sdk-kotlin icon indicating copy to clipboard operation
aws-sdk-kotlin copied to clipboard

s3 custom treatment of GetBucketLocation response

Open kggilmer opened this issue 4 years ago • 1 comments

@jdisanti discovered a discrepancy: S3 documentation specifies a form of XML for the response of GetBucketLocation, and then provides an example that does not follow the specification. @rcoh found that the Go SDK had this issue and implemented a customization to deal with this.

Acceptance criteria:

  • responses to the getBucketLocation operation should deserialize as expected into the response properties.

kggilmer avatar Jun 17 '21 00:06 kggilmer

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to provide a comment or open a new issue.

github-actions[bot] avatar Jul 08 '22 15:07 github-actions[bot]

https://smithy.io/2.0/aws/customizations/s3-customizations.html#aws-customizations-s3unwrappedxmloutput-trait

aajtodd avatar Mar 07 '23 20:03 aajtodd

This seems to have been implemented already in #174, albeit not via s3UnwrappedXmlOutput.

ianbotsf avatar Jun 26 '23 16:06 ianbotsf

From what I've seen in go we may want to share s3 error deserialization across s3 and s3-control. Basically try both wrapped and unwrapped versions (with the default/first attempt being whatever we think it should be based on the model).

aajtodd avatar Jun 26 '23 16:06 aajtodd

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Aug 08 '23 17:08 github-actions[bot]