aws-mobile-appsync-sdk-js icon indicating copy to clipboard operation
aws-mobile-appsync-sdk-js copied to clipboard

fix: check observer exists handleIncomingSubscriptionMessage

Open pckilgore opened this issue 3 years ago • 4 comments

No Issue, although similar in nature to #515 #544 #596 (and PRs #609, #595).

Check observer exists before calling its methods in AppSyncRealTimeSubscriptionHandshakeLink##_handleIncomingSubscriptionMessage

This observer is being defaulted to null here, so I assume checking that and ignoring the event after logging is fine since I would expect the method to bail there rather than initialize to an invalid value? https://github.com/awslabs/aws-mobile-appsync-sdk-js/blob/fc173bfe3ce262b1dba422021fc57097c4926b7b/packages/aws-appsync-subscription-link/src/realtime-subscription-handshake-link.ts#L641

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. I Agree.

pckilgore avatar Jun 15 '21 18:06 pckilgore

Bumping. What can I do here to help get it merged?

pckilgore avatar Sep 20 '21 15:09 pckilgore

Hello again. Can I do anything to assist this is being merged?

pckilgore avatar Mar 01 '22 15:03 pckilgore

It would be really really great if this could be merged 🙏

Dollab avatar Mar 24 '22 16:03 Dollab

I opened a PR that fixes this following the existing code. Please review it: https://github.com/awslabs/aws-mobile-appsync-sdk-js/pull/735

simon-q avatar Oct 27 '22 10:10 simon-q