aws-mobile-appsync-sdk-ios icon indicating copy to clipboard operation
aws-mobile-appsync-sdk-ios copied to clipboard

Published 20 hours ago • verified publisher icon awslabs

Fix: release the session

Open bhushanever opened this issue 3 years ago • 3 comments

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bhushanever avatar Jun 27 '22 12:06 bhushanever

Hi @bhushanever, could you describe why this change is necessary?

dpilch avatar Jun 27 '22 14:06 dpilch

Hi @dpilch,

Actually, in my application, I am using appsync-sdk-ios so while calling API I am facing a memory leak issue, so we tested many times and we come up with this.

Why do we change this:- Since a new session is used for each request, we can safely allow the session to be invalidated after the request has been completed.

@dpilch Please approve this PR.

Thanks in advance.

bhushanever avatar Jun 28 '22 05:06 bhushanever

The change appears to cause the unit and integration tests to fail. Could you take a look and update the tests if necessary?

dpilch avatar Jul 01 '22 17:07 dpilch