aws-deployment-framework icon indicating copy to clipboard operation
aws-deployment-framework copied to clipboard

[Bug]: Terraform extension parameter does not work

Open stemons opened this issue 2 years ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the bug

Terraform extension parameter is not working as expected

Expected Behavior

When the terraform extension parameter is set to true the Dynamo DB table (state file lock) should be created in the deployment account in the ADF main region and all the other regions enabled

Current Behavior

When the terraform extension parameter is set to true the Dynamo DB table (state file lock) has not been created in the deployment account in the ADF main region and all the other regions enabled

Steps To Reproduce

No response

Possible Solution

No response

Additional Information/Context

No response

ADF Version

3.2.0

stemons avatar Feb 03 '23 22:02 stemons

Same problem, i think it's because the parameter /adf/extensions/terraform/enabled has value True but CloudFormation condition wants true as value.

I fixed modifying, in bootstrap repo at the path "adf-bootstrap/deployment/regional.yml", the condition "ADFTerraformExtensionEnabled"

from:

Conditions:
  ADFTerraformExtensionEnabled:
    Fn::Equals:
      - !Ref ADFTerraformExtension
      - true

to:

Conditions:
  ADFTerraformExtensionEnabled:
    Fn::Equals:
      - !Ref ADFTerraformExtension
      - "True"

In this way the condition is evaluated correctly.

LucaCominoli21 avatar Apr 07 '23 16:04 LucaCominoli21