aws-deployment-framework icon indicating copy to clipboard operation
aws-deployment-framework copied to clipboard

Feat/event bus

Open StewartW opened this issue 2 years ago • 3 comments

Issue #, if available:

Description of changes: Introduces an Event Bus to the root account, in the primary region. (us-east-1 if the aws parititon, us-gov-west-1, if the aws-gov partition.) Instruments the account management lambda functions and state machine to emit events on certain actions. Event Bus Policy allows any role within the deployment account and within the adf-automation path to putEvents onto the EventBus.

This enables the Pipeline Management Lambda Functions to push events as well.

Also introduces a new layer for the pipeline management lambda functions that contains the pip installed dependencies and a new aws-xray-sdk requirement, which enables tracing of the lambda functions themselves.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

StewartW avatar Sep 08 '22 11:09 StewartW

Please pull in latest commits from master branch. The new linters will catch some issues like max line length.

javydekoning avatar Sep 14 '22 15:09 javydekoning

Hey @javydekoning Are we allowed to run black now those linter changes are in master? I've always held off using it

StewartW avatar Sep 14 '22 15:09 StewartW

Hey @javydekoning Are we allowed to run black now those linter changes are in master? I've always held off using it

There is no "black" linter yet. However, we are now enforcing a max line length via editorconf. Reformatting the file using black should already help you there and make these long lines a bit easier to read.

javydekoning avatar Sep 14 '22 15:09 javydekoning