aws-deployment-framework icon indicating copy to clipboard operation
aws-deployment-framework copied to clipboard

Move account process to main SAR template

Open sbkok opened this issue 2 years ago • 1 comments

Why?

The SAR does not understand local references as introduced by the src/account_processing.yml unfortunately.

What?

After investigating several options, the only option that was accepted was to move the logic inside the main template instead. The references are updated to use the ones available in the main template directly.

Additionally, the ARN references are updated to include the partition correctly.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sbkok avatar Aug 17 '22 08:08 sbkok

Makes sense. Shame that sam publish and sam deploy have different reactions to this :(

StewartW avatar Aug 17 '22 09:08 StewartW

(Rebased on the latest commit in master to resolve a conflict)

sbkok avatar Aug 19 '22 09:08 sbkok

@javydekoning and @StewartW, I had to resolve a merge conflict. Unfortunately that dismissed the review approvals.

sbkok avatar Aug 23 '22 15:08 sbkok