aws-deployment-framework icon indicating copy to clipboard operation
aws-deployment-framework copied to clipboard

adf-accounts: Should it create new OUs if they don't exists?

Open StewartW opened this issue 4 years ago • 1 comments

ADF Version: 3.0.1 `

  • account_full_name: "some-random-account" --   | organizational_unit_path: /existing/new-ou   | email: [email protected]   | allow_billing: True   | delete_default_vpc: False   | alias: some-random-account   | tags:   | - managed_by_adf: True

`

In this kind of example, when adding a new account via adf-accounts/.yml

It will fail with a ValueError because it can't find the OU. File Here

Do we think this should create the relevant OU if it doesn't exist? What's the thoughts on that? There's pros:

  • allows for smoother creation of OUs and moving accounts "as code"
  • keeps everything in the same process

Cons:

  • Could hide errors if there's a typo in an OU name

StewartW avatar May 20 '20 13:05 StewartW

Hey folks!

I've raised a PR to address this issue, here 🚀

ethanBaird avatar Mar 14 '24 15:03 ethanBaird