aws-deployment-framework icon indicating copy to clipboard operation
aws-deployment-framework copied to clipboard

Approval queries not going to defined slack channel

Open eriklz opened this issue 5 years ago • 2 comments

When setting up a pipeline which has one Slack channel for pipeline notifications and another Slack channel for an approval target, approval queries goes to the pipeline Slack channel, not the approval channel.

Given the following pipeline config and SecretsManager set up with webhooks for both Slack channels below, notifications for pipeline start and completion goes to pipeline-channel. Query for approval also goes to pipeline-channel, despite approval-channel being configured in the approval target.

pipelines:
  - name: the-stuff
    default_providers:
      source:
        provider: codecommit
        properties:
          account_id: "123456789012"
      build:
        provider: codebuild
        properties:
          image: AMAZON_LINUX_2
      deploy:
        provider: codebuild
        properties:
          image: AMAZON_LINUX_2
          spec_filename: deployspec.yml
    params:
      notification_endpoint: pipeline-channel
      restart_execution_on_update: True
    targets:
      - provider: approval
        properties:
          message: New release is ready. Approve?
          notification_endpoint: approval-channel

eriklz avatar Nov 25 '19 09:11 eriklz

Hi @eriklz

Thanks for opening the issue! this is indeed a bug, we'll look into solving this one in the next release!

Regards, Flynn

bundyfx avatar Nov 26 '19 11:11 bundyfx

On further inspection, the functionality you have described does not exist today. However it should work as you have specified above with an approval stage being able to have its own notication_endpoint. We will work towards this in 3.1.

bundyfx avatar Feb 17 '20 11:02 bundyfx

I'm closing this issue as it has been inactive for a long time. This probably means that it is not reproducible or it has been fixed in the meanwhile.

Please reopen if you still encounter this issue with the latest stable version. Thank you!

sbkok avatar May 17 '24 19:05 sbkok