aws-c-common icon indicating copy to clipboard operation
aws-c-common copied to clipboard

Published 20 hours ago • verified publisher icon awslabs

Asan gcc

Open jeremy-coulon opened this issue 3 years ago • 1 comments

Issue #, if available: #884

Description of changes: GCC ASan compatibility

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jeremy-coulon avatar Jan 28 '22 16:01 jeremy-coulon

It seems like there's more needed here. I remembered this PR and came back to it as I'm hoping gcc based asan is easier to get working with a JNI extension than clang, where I'm having no luck. It looks like the basic feature test still fails, as an empty -fsanitize= is an error to gcc (at least 11, which is what I'm trying with). I will try and see if I can update the feature test safely while also incorporating this PR.

bretambrose avatar Sep 01 '22 00:09 bretambrose

@DmitriyMusatkin Are you working on similar changes ?

jeremy-coulon avatar Mar 15 '23 13:03 jeremy-coulon

Didnt realize you already had a PR for this a year ago. Yes, im working on a similar change that will also support msvc and disabling tsan

DmitriyMusatkin avatar Mar 15 '23 16:03 DmitriyMusatkin

addressed in https://github.com/awslabs/aws-c-common/commit/e86e1b6f4622ff8f09d8219d00d79bf8025deaae

DmitriyMusatkin avatar Apr 24 '23 22:04 DmitriyMusatkin