app-development-for-backstage-io-on-aws icon indicating copy to clipboard operation
app-development-for-backstage-io-on-aws copied to clipboard

Unnecessary Gitlab plugin for non-Gitlab installations

Open jsundquist opened this issue 2 years ago • 5 comments

Today I was trying out the plugins and ran into an issue that took me a while to figure out. It seems as though the @aws/plugin-aws-apps-for-backstage has a hard dependency on @immobiliarelabs/backstage-plugin-gitlab.

https://github.com/jsundquist/app-development-for-backstage-io-on-aws/blob/b4ca0946f083dd95272807c86e6c663ae5336dda/backstage-plugins/plugins/aws-apps/src/plugin.ts#L24-L37

Please consider removing the Gitlab gitlab plugin and related dependencies so the plugins can be used in projects that do not require Gitlab.

jsundquist avatar Sep 01 '23 20:09 jsundquist

Hi @jsundquist thanks for your feedback. We currently do have a dependency on immobiliarelabs. In the next few days/weeks we will release a 2nd version of the solution with many more features. However, we have taken a dependency on gitlabs and as a result on immobiliarelabs plugin. We may change this in the future so customers can easily interchange their source control / CI/CD tools.

I'm tagging this as feature request.

z-sourcecode avatar Sep 05 '23 03:09 z-sourcecode

@z-sourcecode I dug through the code after filing the issue and from what I could tell, it looks as though the Gitlab dependency is more for demo purposes to show what a custom CI/CD tab could look like. Would it be possible to move that custom entity page to the demo app and remove it from the plugin itself?

I would be happy to move the code around slight to provide what I described above even if it is short lived until an updated version with different components is released.

jsundquist avatar Sep 05 '23 13:09 jsundquist

Hi @jsundquist , Thanks for your response. that's correct. however we are about to release an updated release that will use gitlab in few places and in our core pipelines as well so at the moment we do have a dependency on gitlab.

z-sourcecode avatar Sep 07 '23 12:09 z-sourcecode

Is there a reason for more gitlab integration? It feels as though then this plugin for Backstage will be discouraging users for GitHub or Bitbucket from using this particular plugin or resorting to forking it to make it more generic.

jsundquist avatar Sep 07 '23 12:09 jsundquist

Yes, we built this a solution for a customer which asked this specifically. that being said , we will plan to accommodate other common CI/CD / SCM tools in the future.

z-sourcecode avatar Sep 07 '23 12:09 z-sourcecode

New multi git support is now published on v0.3.4. https://opaonaws.io/docs/integration/git

z-sourcecode avatar Aug 21 '24 23:08 z-sourcecode

New multi git support is now published on v0.3.4. https://opaonaws.io/docs/integration/git

Hi @z-sourcecode ,

Thank you for the new release (v0.3.4) and for adding support for an additional Git provider!

I was wondering if it's possible to disable GitLab in this version to use GitHub exclusively. Any guidance on configuring this would be greatly appreciated. :)

Thanks again for the great work!

oshriza avatar Oct 14 '24 15:10 oshriza