amazon-kinesis-video-streams-webrtc-sdk-js icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-js copied to clipboard

call get ice servers when offer is received to avoid stale ice server…

Open chehefen opened this issue 4 years ago • 2 comments

… credential

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chehefen avatar Aug 13 '20 22:08 chehefen

This fixes the issue of stale ice server credentials but RTCPeerConnection.setConfiguration() is not supported in Firefox.

abrenaut avatar Aug 14 '20 01:08 abrenaut

So a tradeoff with this approach is that the startup time might be increased due to having to fetch a new ICEServerConfig before the browser can start gathering ICE candidates on the master side.

  • Am I perhaps missing something on the potential latency impact?
  • Are there any alternative ways to accomplish the same thing (having non-stale TURN credentials)? Perhaps the master could periodically refresh the TURN credentials instead? Or even keep a pool of non-stale credentials?

MixMasterMitch avatar Aug 24 '20 16:08 MixMasterMitch