amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

[BUG] Answer m-lines should match offer m-lines even when answerer doesn't support media type

Open hassanctech opened this issue 4 years ago • 2 comments

Describe the bug The master sample right now adds audio/video transceivers. If we modify it to only have video -- when replying to an offer which has recvonly audio, instead of sending an m-line it will send nothing.

Need to modify the logic that determines the response to match m-lines in offer even when local transceivers might not have matching media.

SDK version number eac3e1656aa01b3f3d730fb80272d062fd7cb538 (latest)

Open source building

To Reproduce Steps to reproduce the behavior:

  1. Modify master sample to have video only
  2. Run test page (https://awslabs.github.io/amazon-kinesis-video-streams-webrtc-sdk-js/examples/index.html) in Chrome and select audio and video
  3. Start master, and then start viewer
  4. See error about non-matching m-lines

Expected behavior The answer (from the master side) should contain an m-line for audio but the direction can indicate it's not actually supported

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Browser Chrome
  • Version [e.g. 22]

hassanctech avatar Sep 17 '20 13:09 hassanctech

It looks like this issue has not been active for a long time. If the issue is not resolved, please add an update to the ticket, else it will be automatically resolved in a few days.

github-actions[bot] avatar Aug 19 '21 21:08 github-actions[bot]

The work has not been initiated yet.

disa6302 avatar Aug 19 '21 21:08 disa6302

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Nov 06 '22 00:11 github-actions[bot]