amazon-kinesis-video-streams-webrtc-sdk-c
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard
Dual-Stack Endpoints Support
Issue #, if available: N/A
What was changed?
- Added support for sample applications to be able to specify to use dual-stack endpoints for KVS.
- This will allow applications to opt-in to using dual-stack (IPv4 & IPv6-supported) endpoints while leaving the legacy (IPv4-only) endpoints to be the default mode.
- The Common.c sample file now demonstrates how to generate a dual-stack Control Plane endpoint based on the configured region.
- Gathered the
createSampleConfigurationfunction's parameters, including the newuseDualStackEndpointsparameter, into a single struct to avoid excessively long function signature.
[!NOTE] The name for this new
useDualStackEndpointsparameter is plural because using the dual-stack Control Plane endpoint (once it is ready) will result in a dual-stack signaling channel server endpoint which will result in dual-stack TURN server URIs. It also will likely control legacy/dual-stack of the KVS STUN server endpoint that is also constructed in the application.
Why was it changed?
- For testing and demonstrating dual-stack endpoints.
How was it changed?
- By adding the relevant parameter and moving
MAX_CONTROL_PLANE_URI_CHAR_LENinto a public header file for the application to access it.
What testing was done for the changes?
- Added unit tests to ensure that passed-in custom endpoints get set when constructing and validating ClientInfo object.
- Will add CI tests configured to use the dual-stack endpoints once they are ready.
- These code changes only work with public endpoints; have not tested with the public endpoints yet because they are not yet ready.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
[!IMPORTANT] Remember to revert Producer C SDK tag before merging!
This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.