amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

Fix turn data mode parameter and enum member name

Open stefankiesz opened this issue 9 months ago • 0 comments

What was changed?

  • The TURN_CONNECTION_DATA_TRANSFER_MODE parameter passed into the createTurnConnection call in iceAgentInitRelayCandidate.
  • The name of one of the members of the TURN_CONNECTION_DATA_TRANSFER_MODE enum.

Why was it changed?

  • The passed parameter was changed because not only is it not used, the enum value that parameter is to set gets hardcoded in the same function to be a different enum value from the one passed in making it very confusing.
  • The enum member name had a typo.

How was it changed?

  • The passed parameter was changed to NULL.
  • The typo was corrected.

What testing was done for the changes?

  • Allowing for the CI tests to pass.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

stefankiesz avatar Mar 05 '25 05:03 stefankiesz