Change onSctpOutboundPacket 3rd parameter type to SIZE_T
Issue #, if available: https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/issues/2094, #2065
What was changed?
The 3rd parameter of the onSctpOutboundPacket function.
Why was it changed?
To match the expected pointer-function signature of the second parameter of the usrsctp_init_nothreads function as defined here in the Usrsctp library.
How was it changed? The parameter was changed from a ULONG to a SIZE_T.
What testing was done for the changes? Will confirm from user that this resolved the issue, and will allow for the CI to pass.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
The CI confirms that PIC's SIZE_T macro does not match the actual size_t in certain cases, and the original authors went with ULONG as a workaround.
https://github.com/awslabs/amazon-kinesis-video-streams-pic/blob/c98c2a256a7bb3dfc4db41ae26d45e28ac7eec56/src/common/include/com/amazonaws/kinesis/video/common/CommonDefs.h#L329-L338
May need to do some more digging into why the original authors didn't use:
#include <stddef.h>
typedef size_t SIZE_T;
This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.