amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

Published 20 hours ago • verified publisher icon awslabs

Fix retransmitter bug

Open hassanctech opened this issue 9 months ago • 1 comments

Issue #, if available: https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/issues/1991, https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/issues/1453

What was changed?

  • Added a diagram to show the memory layout for the ReTransmitter struct.
  • Fixed a bug where where an index for sequenceNumberList may go out of bounds but is hard to detect / won't cause a crash because in memory the next memory spot when we go out of bounds is into the validIndexList, and unless it's size is zero (which is likely never the case) we will not actually go out of bounds but instead we will overwrite a value in the wrong list.
  • Fixed an issue where we are reading an index from one list but updating the value in a different list.

Why was it changed?

  • Multiple reported customer issues, see at top.

How was it changed? See What was changed section and the file diff.

What testing was done for the changes? CI. [TODO] More targeted tests need to be added, will remove this once it has been added.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hassanctech avatar May 23 '24 17:05 hassanctech