amazon-kinesis-video-streams-webrtc-sdk-c
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard
[Feature] Add AAC Support
Issue #, if available:
- Running the CI for https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/pull/1945 and addressing all the comments and fixes
What was changed?
- Added support for AAC in RTP and SDP
Why was it changed?
- This is new feature to expand support for different codecs
How was it changed?
- Introduced AAC payloader and de-payloader in RTP
- Modified the SessionDescription.c to include AAC in offer and answer
What testing was done for the changes?
- Used #1963 with kvsWebrtcClientMasterGstSample and kvsWebrtcClientMaster as master and kvsWebrtcClientViewerGstSample as viewer with H264/AAC only and H265/AAC
build % ffprobe -v error -show_entries stream=codec_name,sample_rate,width,height,channels -of default=noprint_wrappers=1 video.mkv
codec_name=h264
width=1280
height=720
codec_name=aac
sample_rate=16000
channels=2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Attention: Patch coverage is 64.91228% with 20 lines in your changes are missing coverage. Please review.
Project coverage is 88.51%. Comparing base (
a28e1e4) to head (8f5b0c1).
:exclamation: Current head 8f5b0c1 differs from pull request most recent head 2f21e35. Consider uploading reports for the commit 2f21e35 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #1966 +/- ##
===========================================
- Coverage 88.60% 88.51% -0.09%
===========================================
Files 47 48 +1
Lines 12697 12750 +53
===========================================
+ Hits 11250 11286 +36
- Misses 1447 1464 +17
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.