amazon-kinesis-video-streams-webrtc-sdk-c
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard
Openssl 3.1.3
Issue #, if available:
What was changed? Added support for OpenSSL 3.x version in the SDK
Why was it changed? OpenSSL 1.1.1x went EOL in September 2023 and some of the APIs that the SDK uses are deprecated which mostly show up as warnings. This means these APIs could be removed in the future. To ensure we are up to date, this PR introduces support for OpenSSL 3.x, while also maintaining support for older OpenSSL versions.
How was it changed?
- Used
OPENSSL_VERSION_NUMBERdefine to switch the APIs used where relevant. - Added a new cmake property:
BUILD_OLD_OPENSSL_VERSIONto allow building older version from source (1.1.1w) if3.1.3causes issues. System dependencies could also be used instead if applications/platforms require using older version, however, this property covers situations for applications that build the dependencies from source in our SDK - Added CI jobs for different platforms to test of older OpenSSL version
What testing was done for the changes?
- Local testing was done for RSA certificate generation and EC certificate generation to confirm the new APIs work
- For MD5, the hash was logged to compare the values between 1.1.1x and 3.x version
- Existing benchmark was used to verify no performance degradation in the handshake process.
- CI was used to fix build failures on Windows and ARM cross compilation that came with the upgrade
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
feba4d3) 74.84% compared to head (7027a1c) 74.87%.
:exclamation: Current head 7027a1c differs from pull request most recent head 90ba931. Consider uploading reports for the commit 90ba931 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #1840 +/- ##
===========================================
+ Coverage 74.84% 74.87% +0.03%
===========================================
Files 48 48
Lines 12844 12844
===========================================
+ Hits 9613 9617 +4
+ Misses 3231 3227 -4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.
This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.