amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

Fix the problem that the session is not released when handleOffer processing fails

Open Kelephant opened this issue 2 years ago • 1 comments

Fix the problem that the session is not released when handleOffer processing fails

Kelephant avatar Aug 26 '22 16:08 Kelephant

Codecov Report

Merging #1543 (5d5f446) into master (ced19d0) will increase coverage by 0.00%. The diff coverage is 0.00%.

:exclamation: Current head 5d5f446 differs from pull request most recent head f5fe038. Consider uploading reports for the commit f5fe038 to get more accurate results

@@           Coverage Diff           @@
##           master    #1543   +/-   ##
=======================================
  Coverage   51.30%   51.31%           
=======================================
  Files          46       46           
  Lines       12822    12820    -2     
=======================================
  Hits         6578     6578           
+ Misses       6244     6242    -2     
Impacted Files Coverage Δ
samples/Common.c 0.00% <0.00%> (ø)
samples/kvsWebRTCClientMaster.c 0.00% <0.00%> (ø)
samples/kvsWebRTCClientViewer.c 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 26 '22 16:08 codecov-commenter

Hi @Kelephant, thank you for your contribution. Can you please rebase this to the latest changes in develop and open this PR against develop and fix the failing builds?

niyatim23 avatar Feb 09 '23 19:02 niyatim23

Closing in favor of the linked PR

niyatim23 avatar Mar 17 '23 21:03 niyatim23