amazon-kinesis-video-streams-webrtc-sdk-c
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard
fix turn allocation taken long time when credential is incorrect
Issue #, if available: turn allocation taken long time when credential is incorrect. It taken about 10s+ until the local candidate gathering timeout
Description of changes:
- add trunStateFailedFn, called when turn state change to TURN_STATE_FAILED, and then update pNewCandidate state from ICE_CANDIDATE_STATE_NEW to ICE_CANDIDATE_STATE_INVALID
- add stateTryCountMax and stateTryCount, limit the allocation times not more than stateTryCountMax
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Merging #1536 (29b996e) into develop (8f7ba52) will decrease coverage by
0.08%. The diff coverage is0.00%.
:exclamation: Current head 29b996e differs from pull request most recent head e7e6621. Consider uploading reports for the commit e7e6621 to get more accurate results
@@ Coverage Diff @@
## develop #1536 +/- ##
===========================================
- Coverage 52.15% 52.06% -0.09%
===========================================
Files 46 46
Lines 12796 12814 +18
===========================================
- Hits 6674 6672 -2
- Misses 6122 6142 +20
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/source/Ice/IceAgent.c | 85.14% <0.00%> (-0.67%) |
:arrow_down: |
| src/source/Ice/TurnConnection.c | 0.00% <0.00%> (ø) |
|
| src/source/Ice/ConnectionListener.c | 90.50% <0.00%> (-1.00%) |
:arrow_down: |
| samples/kvsWebRTCClientMaster.c | 0.00% <0.00%> (ø) |
|
| samples/kvsWebRTCClientViewer.c | 0.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hi @vc60er thanks for your contribution. Could you please rebase to latest develop branch so we can get this merged in?
Closing since the PR with the fixed CI has been merged. Thanks for your contribution