amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

fix MbedTLS building failure with clang on macOS

Open northteam opened this issue 2 years ago • 2 comments

Issue #, if available:

Description of changes: When building MbedTLS with clang on macOS, an 'unused-but-set-parameter' error will be emitted on 'library/psa_crypto.c'.

[ 28%] Building C object library/CMakeFiles/mbedcrypto_static.dir/poly1305.c.o [ 28%] Building C object library/CMakeFiles/mbedcrypto_static.dir/psa_crypto.c.o /Volumes/CaseSensitive/src/amazon-kinesis-video-streams-webrtc-sdk-c/open-source/libmbedtls/build/src/project_libmbedtls/library/psa_crypto.c:4590:12: error: parameter 'output_size' set but not used [-Werror,-Wunused-but-set-parameter] size_t output_size, ^ 1 error generated. make[5]: *** [library/CMakeFiles/mbedcrypto_static.dir/psa_crypto.c.o] Error 1

This patch treat this as a warning when using clang.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

northteam avatar Jun 14 '22 11:06 northteam

@northteam ,

It looks like your change breaks ubuntu clang build.

disa6302 avatar Jul 28 '22 16:07 disa6302

@northteam ,

It looks like your change breaks ubuntu clang build.

Yeah, I will try to fix it some time.

northteam avatar Jul 29 '22 03:07 northteam

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Jan 26 '23 00:01 github-actions[bot]

Hi @northteam, thank you for your contribution. Can you please rebase this to the latest changes in develop and fix the failing builds?

niyatim23 avatar Feb 09 '23 19:02 niyatim23

Closing this PR since the fix fails mbedtls-ubuntu-clang check. Please open a new PR / request to re-open this PR if you have a fix

niyatim23 avatar Mar 17 '23 16:03 niyatim23