amazon-kinesis-video-streams-webrtc-sdk-c
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard
wrong port/address in debug log
Issue #, if available: in master debug log prints
iceCandidatePairCheckConnection(): remote ip:192.168.254.75, port:192, local ip:49360.168.1.130, port:192
notice port is 192 while local ip starts with 49360
Description of changes:
prints as expected
iceCandidatePairCheckConnection(): remote ip:192.168.254.75, port:49360, local ip:192.168.1.130, port:39362
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Merging #1495 (acbfe52) into master (ced19d0) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #1495 +/- ##
=======================================
Coverage 51.30% 51.30%
=======================================
Files 46 46
Lines 12822 12822
=======================================
Hits 6578 6578
Misses 6244 6244
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/source/Ice/IceAgent.c | 85.29% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ced19d0...acbfe52. Read the comment docs.
@zhuker ,
Thank you! Can you direct this PR to the develop branch instead?
This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.
Closing in favor of https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/pull/1642#