amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

Fix missing SDP m-line problem

Open niyatim23 opened this issue 2 years ago • 1 comments

Issue #, if available: https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/issues/867 https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/issues/803

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

niyatim23 avatar Apr 25 '22 22:04 niyatim23

Codecov Report

Merging #1458 (3eb6c34) into develop (866aee4) will increase coverage by 0.34%. The diff coverage is 94.59%.

:exclamation: Current head 3eb6c34 differs from pull request most recent head 72f8db4. Consider uploading reports for the commit 72f8db4 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1458      +/-   ##
===========================================
+ Coverage    51.50%   51.84%   +0.34%     
===========================================
  Files           46       46              
  Lines        12794    12880      +86     
===========================================
+ Hits          6589     6678      +89     
+ Misses        6205     6202       -3     
Impacted Files Coverage Δ
samples/Common.c 0.00% <0.00%> (ø)
src/source/PeerConnection/SessionDescription.c 89.73% <99.24%> (+1.59%) :arrow_up:
src/source/PeerConnection/PeerConnection.c 81.45% <100.00%> (+0.20%) :arrow_up:
samples/kvsWebRTCClientMaster.c 0.00% <0.00%> (ø)
samples/kvsWebRTCClientViewer.c 0.00% <0.00%> (ø)
src/source/Ice/IceAgent.c 86.47% <0.00%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 866aee4...72f8db4. Read the comment docs.

codecov-commenter avatar Apr 27 '22 00:04 codecov-commenter

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Dec 26 '22 00:12 github-actions[bot]