amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

Published 20 hours ago • verified publisher icon awslabs

[BUG] CI build fails due to missing secrets

Open thinkski opened this issue 2 years ago • 7 comments

sample-check CI workflow is failing -- secrets are unavailable to CI:

Error: Input required and not supplied: aws-region

thinkski avatar Feb 23 '22 23:02 thinkski

@thinkski ,

It is not a bug but the nature of GHA CI that does not allow using secrets on forked branches. We will look into it.

disa6302 avatar Feb 23 '22 23:02 disa6302

Thank you. It's showing up on PR CI builds (e.g. PR #1411)

thinkski avatar Feb 24 '22 00:02 thinkski

Hi @thinkski, thank you for bringing this up. I have an update to fix this in the develop branch. Can you please rebase from develop to see if it works for you?

niyatim23 avatar Feb 25 '22 19:02 niyatim23

@thinkski , Can you please rebase your PR to pick the changes? Thank you!

disa6302 avatar Mar 03 '22 00:03 disa6302

Closing due to no response. @thinkski , please rebase your PR to include the change. We will reopen if the test still fails

disa6302 avatar Mar 09 '22 07:03 disa6302

@disa6302 Sorry, didn't see this earlier. I rebased on the Feb 25 commit b4f4516. Unfortunately, still encounter same issue.

thinkski avatar Mar 09 '22 07:03 thinkski

We will look into this then. Thank you for confirming!

disa6302 avatar Mar 09 '22 07:03 disa6302

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Nov 20 '22 00:11 github-actions[bot]

Should be fixed as of #1631 and #1634

sirknightj avatar Feb 10 '23 23:02 sirknightj