amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

Update kvsWebRTCClientMasterGstreamerSample.c - Provide Raspberry Pi hardware encode example

Open bkneff opened this issue 3 years ago • 5 comments

Provide an example gstreamer pipeline for Raspberry Pi hardware encoding. Tested on Raspberry Pi 3

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bkneff avatar Feb 13 '22 00:02 bkneff

Codecov Report

Merging #1398 (104d801) into develop (19e0f14) will increase coverage by 0.00%. The diff coverage is 70.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1398   +/-   ##
========================================
  Coverage    51.49%   51.49%           
========================================
  Files           46       46           
  Lines        12795    12802    +7     
========================================
+ Hits          6589     6593    +4     
- Misses        6206     6209    +3     
Impacted Files Coverage Δ
samples/kvsWebRTCClientMaster.c 0.00% <0.00%> (ø)
src/source/Ice/IceAgent.c 86.47% <ø> (+0.19%) :arrow_up:
src/source/Signaling/LwsApiCalls.c 1.53% <ø> (ø)
src/source/Signaling/Signaling.c 11.58% <ø> (ø)
src/source/PeerConnection/PeerConnection.c 80.68% <100.00%> (-0.57%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19e0f14...104d801. Read the comment docs.

codecov-commenter avatar Feb 13 '22 00:02 codecov-commenter

Thank you @bkneff ! Can you direct this PR to origin/develop branch instead of master?

disa6302 avatar Feb 14 '22 16:02 disa6302

I just changed the branch to develop.

bkneff avatar Feb 14 '22 19:02 bkneff

@bkneff there were a ton of merge conflicts, I resolved them all, so as soon as the merge commit travis run succeeds we can get this merged.

hassanctech avatar Feb 17 '22 16:02 hassanctech

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Aug 17 '22 00:08 github-actions[bot]

Thanks @bkneff for this, was really helpful despite not being merged in the repo

cyuste avatar Dec 16 '22 18:12 cyuste

Closed in favor of #1640 .

Thank you for your contribution @bkneff !

sirknightj avatar Feb 11 '23 00:02 sirknightj