amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

Use DTLS_method for openssl >= 1.0.2

Open AndyLc opened this issue 2 years ago • 2 comments

Issue #, if available:

Description of changes: DTLSv2 is available for openssl >= 1.0.2, so use DTLSv2 when available.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AndyLc avatar Dec 23 '21 00:12 AndyLc

Codecov Report

Merging #1360 (ae9a8e4) into master (4127014) will decrease coverage by 28.18%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1360       +/-   ##
===========================================
- Coverage   85.83%   57.64%   -28.19%     
===========================================
  Files          42       42               
  Lines       10600    10600               
===========================================
- Hits         9098     6110     -2988     
- Misses       1502     4490     +2988     
Impacted Files Coverage Δ
src/source/Crypto/Dtls_openssl.c 94.55% <ø> (ø)
src/source/Crypto/Tls.c 0.00% <0.00%> (-100.00%) :arrow_down:
src/source/Ice/TurnConnection.c 0.00% <0.00%> (-93.34%) :arrow_down:
src/source/Signaling/ChannelInfo.c 0.00% <0.00%> (-88.03%) :arrow_down:
src/source/Crypto/Tls_openssl.c 0.00% <0.00%> (-84.30%) :arrow_down:
src/source/Signaling/Signaling.c 11.32% <0.00%> (-83.78%) :arrow_down:
src/source/Signaling/LwsApiCalls.c 1.33% <0.00%> (-82.74%) :arrow_down:
src/source/Signaling/StateMachine.c 0.00% <0.00%> (-81.45%) :arrow_down:
src/source/Ice/SocketConnection.c 50.90% <0.00%> (-28.83%) :arrow_down:
src/source/Signaling/FileCache.c 73.87% <0.00%> (-23.43%) :arrow_down:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4127014...ae9a8e4. Read the comment docs.

codecov-commenter avatar Dec 23 '21 00:12 codecov-commenter

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Jun 22 '22 00:06 github-actions[bot]