Added 1-20% jitter to expiration value stored by AwsCredentials struc…

[jdelapla]

…t in producer-c.

Modified stepSignaling to include a check for expiration of credentials. This is part of a larger effort to help customers with large fleets distribute the timings of their attempts to reconnect to our servers.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[hassanctech]

SignalingApiFunctionalityTest.deleteChannelCreatedAuthExpiration is failing

[codecov-commenter]

Codecov Report

Merging #1315 (99fdca8) into develop (e243e20) will decrease coverage by 0.17%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1315      +/-   ##
===========================================
- Coverage    85.96%   85.78%   -0.18%     
===========================================
  Files           42       42              
  Lines        10602    10604       +2     
===========================================
- Hits          9114     9097      -17     
- Misses        1488     1507      +19     

Impacted Files	Coverage Δ
src/source/Signaling/StateMachine.c	82.47% <100.00%> (+1.03%)	:arrow_up:
src/source/Ice/SocketConnection.c	79.72% <0.00%> (-4.06%)	:arrow_down:
src/source/Crypto/Tls_openssl.c	82.64% <0.00%> (-1.66%)	:arrow_down:
src/source/Ice/IceUtils.c	96.03% <0.00%> (-1.59%)	:arrow_down:
src/source/Ice/IceAgentStateMachine.c	83.90% <0.00%> (-1.37%)	:arrow_down:
src/source/Ice/ConnectionListener.c	92.14% <0.00%> (-0.49%)	:arrow_down:
src/source/Ice/IceAgent.c	94.21% <0.00%> (-0.35%)	:arrow_down:
src/source/Ice/TurnConnection.c	93.46% <0.00%> (+<0.01%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e243e20...99fdca8. Read the comment docs.

[MushMal]

I provided some feedback on

https://github.com/awslabs/amazon-kinesis-video-streams-producer-c/pull/254#issuecomment-956453242

Also, the PIC solution to jitter has a threshold below which jitter is not applied. Is there a good reason to add jitter to IoT credential provider at all? What about the other providers? Perhaps a better approach is to leave the providers alone and handle the jitter on the "consumer" side - i.e. the signaling client in this case.

[github-actions[bot]]

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.