Issue #, if available: by default libusrsctp uses DEBUG build type https://github.com/sctplab/usrsctp/blob/master/CMakeLists.txt#L37

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

May 25 '21 23:05 chertov

Codecov Report

Merging #1150 (59e21a2) into master (ced19d0) will increase coverage by 6.10%. The diff coverage is n/a.

:exclamation: Current head 59e21a2 differs from pull request most recent head 8420366. Consider uploading reports for the commit 8420366 to get more accurate results

@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
+ Coverage   51.30%   57.40%   +6.10%     
==========================================
  Files          46       42       -4     
  Lines       12822    10577    -2245     
==========================================
- Hits         6578     6072     -506     
+ Misses       6244     4505    -1739

Impacted Files	Coverage Δ
src/source/PeerConnection/PeerConnection.c	`79.57% <0.00%> (-1.68%)`	:arrow_down:
src/source/PeerConnection/Retransmitter.c	`85.33% <0.00%> (-0.92%)`	:arrow_down:
src/source/PeerConnection/jsmn.h	`72.93% <0.00%> (-0.87%)`	:arrow_down:
src/source/Ice/IceAgentStateMachine.c	`70.20% <0.00%> (-0.74%)`	:arrow_down:
src/source/Signaling/FileCache.c	`73.87% <0.00%> (-0.72%)`	:arrow_down:
src/source/Sdp/Deserialize.c	`86.95% <0.00%> (-0.72%)`	:arrow_down:
src/source/Rtp/Codecs/RtpVP8Payloader.c	`80.00% <0.00%> (-0.60%)`	:arrow_down:
src/source/Rtp/Codecs/RtpOpusPayloader.c	`88.88% <0.00%> (-0.59%)`	:arrow_down:
src/source/Ice/Network.c	`72.04% <0.00%> (-0.57%)`	:arrow_down:
src/source/Rtp/Codecs/RtpG711Payloader.c	`90.00% <0.00%> (-0.48%)`	:arrow_down:
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ced19d0...8420366. Read the comment docs.

May 26 '21 00:05 codecov-commenter

@MushMal Not sure I mentioned this before. I created on PR on usrsctp for the support of mbedtls. https://github.com/sctplab/usrsctp/pull/579. It is merged into main trunk already. Maybe the team want to upgrade the version of usrsctp.

Jun 02 '21 06:06 ycyang1229

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

May 19 '22 00:05 github-actions[bot]

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

Dec 04 '22 00:12 github-actions[bot]

Closing since this PR fails checks and is stale. Please edit this PR to fix the builds, change the base branch to develop and reopen this

Mar 17 '23 17:03 niyatim23

Set build type for libusrsctp

Codecov Report