amazon-kinesis-video-streams-producer-sdk-cpp icon indicating copy to clipboard operation
amazon-kinesis-video-streams-producer-sdk-cpp copied to clipboard

Add PutEventMetadata support for JNI

Open stefankiesz opened this issue 11 months ago • 1 comments

What was changed? Adds JNI implementation for putKinesisVideoEventMetadata. Coincides with the following Java SDK PR: https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-java/pull/193.

Why was it changed? To bring PutEventMetadata support into the Java Producer SDK.

How was it changed? By adding the relevant JNI definitions, and allocating and deallocating memory for the necessary parameters.

What testing was done for the changes? The CI passing, and manually testing using the Java SDK DemoApp. See the corresponding Java PR for more testing details.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

stefankiesz avatar Mar 28 '24 02:03 stefankiesz

Codecov Report

Attention: Patch coverage is 0% with 92 lines in your changes are missing coverage. Please review.

Project coverage is 16.27%. Comparing base (ca558f7) to head (11d8785).

:exclamation: Current head 11d8785 differs from pull request most recent head 26a0771. Consider uploading reports for the commit 26a0771 to get more accurate results

Files Patch % Lines
...mazonaws/kinesis/video/producer/jni/Parameters.cpp 0.00% 60 Missing :warning:
...s/video/producer/jni/KinesisVideoClientWrapper.cpp 0.00% 32 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1160      +/-   ##
===========================================
- Coverage    16.48%   16.27%   -0.21%     
===========================================
  Files           50       50              
  Lines         7019     7109      +90     
===========================================
  Hits          1157     1157              
- Misses        5862     5952      +90     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 28 '24 03:03 codecov-commenter