amazon-kinesis-client icon indicating copy to clipboard operation
amazon-kinesis-client copied to clipboard

[1.x] Why many overloads of `KinesisClientLibConfiguration` have been marked as deprecated?

Open issei-m opened this issue 4 years ago • 9 comments

Since this commit https://github.com/awslabs/amazon-kinesis-client/commit/6f16b168a4fbd559a4c76956421bfbd9e4c99293, it seems you marked many overloads of constructors of the class KinesisClientLibConfiguration as deprecated without any alternative suggestions. How can I instantiate this class from then? I don't want to think this one which is required full arguments would be... Passing a lot of defaults to the constructor is a somewhat boring me :(

issei-m avatar Aug 25 '20 05:08 issei-m

It appears that the caller is expected to use a builder pattern/the withXXX methods, but there's no default constructor to facilitate it.

jackl avatar Sep 08 '20 16:09 jackl

Nobody from the dev team to chime in?

Was it a mistake to deprecate them? If not maybe the javadoc of the deprecated constructors should be updated with the new "recommended way"?

My build system is configured to change warnings to errors so if it's deprecated, I can't use it.

erwan avatar Sep 11 '20 07:09 erwan

super wired

xinatcg avatar Nov 26 '20 21:11 xinatcg

This is really a problem. It needs to be fixed ASAP.

blindpirate avatar Jan 05 '21 11:01 blindpirate

We actually wanted to migrate this to a builder with essential args constructor. Will release a fix shortly.

ashwing avatar Jan 05 '21 20:01 ashwing

Is this fixed yet? I also don't want to use this https://github.com/awslabs/amazon-kinesis-client/blob/v1.x/src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/KinesisClientLibConfiguration.java#L636.

How exactly to use builder?

marinkreso95 avatar Mar 12 '21 08:03 marinkreso95

We actually wanted to migrate this to a builder with essential args constructor. Will release a fix shortly.

Nine months later... 😂

saniaky avatar Sep 20 '21 20:09 saniaky

We actually wanted to migrate this to a builder with essential args constructor. Will release a fix shortly.

Nine months later... 😂

Twenty-one months later...

ponyFan avatar Oct 14 '22 06:10 ponyFan

We actually wanted to migrate this to a builder with essential args constructor. Will release a fix shortly.

Nine months later... 😂

Twenty-one months later...

Thirty-three months later... 😅

anskaal avatar Oct 09 '23 06:10 anskaal