amazon-kinesis-agent icon indicating copy to clipboard operation
amazon-kinesis-agent copied to clipboard

feat: Allow environment variable expansion in agent.json

Open frankfarrell opened this issue 6 years ago • 3 comments

For instance, if there is an env variable AWS_REGION, allow the following config to be valid:

{
    "cloudwatch.emitMetrics": true,
    "kinesis.endpoint": "kinesis.${AWS_REGION}.amazonaws.com", 
    "firehose.endpoint": "firehose.${AWS_REGION}.amazonaws.com"
...etc
}

frankfarrell avatar Mar 14 '18 12:03 frankfarrell

I would like to work on this. Can you assign this to me? @chaochenq

gorkemmulayim avatar Oct 31 '18 16:10 gorkemmulayim

That would be great, thanks @RootG, although your name doesn't show up in the assigning list, i don't know how to assign it to you.

chaochenq avatar Oct 31 '18 16:10 chaochenq

@chaochenq Hi, it has been a while since I have opened a pull request about this issue. I believe the pull request changes will resolve the issue. Can you please review it?

gorkemmulayim avatar Feb 18 '19 12:02 gorkemmulayim