amazon-eks-serverless-drainer icon indicating copy to clipboard operation
amazon-eks-serverless-drainer copied to clipboard

auto discovered cluster name is not actually set

Open marsel-tron opened this issue 5 years ago • 0 comments

Code parses the cluster name from ec2 instance tag according to this line - https://github.com/awslabs/amazon-eks-serverless-drainer/blob/master/main.sh#L37-L38

But when setting kubeconfig, it's using cluster_name variable which is different from the parsed cluster name (input_cluster_name) - https://github.com/awslabs/amazon-eks-serverless-drainer/blob/master/main.sh#L41

By default, when you deploy with a click of a button, it doesn't set the cluster_name variable at all. And now I am wondering how is this expected to work? Also note: The lambda function itself doesn't handle errors well and makes everything look like it has worked

marsel-tron avatar Apr 29 '20 17:04 marsel-tron