amazon-eks-ami icon indicating copy to clipboard operation
amazon-eks-ami copied to clipboard

build(al2023): update to kernel 6.12 for 1.30+

Open ndbaker1 opened this issue 7 months ago • 24 comments

Issue #, if available:

Description of changes:

Bumping the AL2023 kernel version to 6.12 in k8s 1.30+ (take no.2)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

ndbaker1 avatar Apr 24 '25 20:04 ndbaker1

/ci +build enable_accelerator=neuron enable_efa=true

ndbaker1 avatar Apr 24 '25 20:04 ndbaker1

@ndbaker1 roger that! I've dispatched a workflow. 👍

github-actions[bot] avatar Apr 24 '25 20:04 github-actions[bot]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.25 / al2023success ✅success ✅
1.26 / al2023success ✅success ✅
1.27 / al2023success ✅success ✅
1.28 / al2023success ✅success ✅
1.29 / al2023success ✅success ✅
1.30 / al2023success ✅success ✅
1.31 / al2023success ✅success ✅
1.32 / al2023success ✅success ✅

github-actions[bot] avatar Apr 24 '25 23:04 github-actions[bot]

seems like the builds aren't actually passing, they've got dkms build errors for neuron modules, https://github.com/awslabs/amazon-eks-ami/actions/runs/14651179225/job/41121304686#step:4:2344

ndbaker1 avatar Apr 25 '25 01:04 ndbaker1

added a new validation step for dkms modules

/ci +build enable_accelerator=neuron enable_efa=true

ndbaker1 avatar Apr 25 '25 21:04 ndbaker1

@ndbaker1 roger that! I've dispatched a workflow. 👍

github-actions[bot] avatar Apr 25 '25 21:04 github-actions[bot]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.25 / al2023failure ❌skipped ⏭️
1.26 / al2023failure ❌skipped ⏭️
1.27 / al2023failure ❌skipped ⏭️
1.28 / al2023failure ❌skipped ⏭️
1.29 / al2023failure ❌skipped ⏭️
1.30 / al2023failure ❌skipped ⏭️
1.31 / al2023failure ❌skipped ⏭️
1.32 / al2023failure ❌skipped ⏭️

github-actions[bot] avatar Apr 25 '25 22:04 github-actions[bot]

neuron install was also pulling in 6.12 kernel packages on 6.1 version. testing again after pre-installing the packages using the current running kernel.

/ci +build enable_accelerator=neuron enable_efa=true

ndbaker1 avatar Apr 25 '25 22:04 ndbaker1

@ndbaker1 roger that! I've dispatched a workflow. 👍

github-actions[bot] avatar Apr 25 '25 22:04 github-actions[bot]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.25 / al2023success ✅success ✅
1.26 / al2023success ✅success ✅
1.27 / al2023success ✅success ✅
1.28 / al2023success ✅success ✅
1.29 / al2023success ✅success ✅
1.30 / al2023failure ❌skipped ⏭️
1.31 / al2023failure ❌skipped ⏭️
1.32 / al2023failure ❌skipped ⏭️

github-actions[bot] avatar Apr 25 '25 23:04 github-actions[bot]

/ci +build enable_accelerator=neuron enable_efa=true

ndbaker1 avatar Apr 30 '25 17:04 ndbaker1

@ndbaker1 roger that! I've dispatched a workflow. 👍

github-actions[bot] avatar Apr 30 '25 17:04 github-actions[bot]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.25 / al2023success ✅success ✅
1.26 / al2023success ✅success ✅
1.27 / al2023success ✅success ✅
1.28 / al2023success ✅success ✅
1.29 / al2023success ✅success ✅
1.30 / al2023failure ❌skipped ⏭️
1.31 / al2023failure ❌skipped ⏭️
1.32 / al2023failure ❌skipped ⏭️

github-actions[bot] avatar Apr 30 '25 18:04 github-actions[bot]

/ci +build enable_accelerator=neuron enable_efa=true

ndbaker1 avatar May 05 '25 19:05 ndbaker1

@ndbaker1 roger that! I've dispatched a workflow. 👍

github-actions[bot] avatar May 05 '25 19:05 github-actions[bot]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.26 / al2023success ✅success ✅
1.27 / al2023success ✅success ✅
1.28 / al2023success ✅success ✅
1.29 / al2023success ✅success ✅
1.30 / al2023failure ❌skipped ⏭️
1.31 / al2023failure ❌skipped ⏭️
1.32 / al2023failure ❌skipped ⏭️

github-actions[bot] avatar May 05 '25 20:05 github-actions[bot]

/ci build +build enable_accelerator=neuron enable_efa=true

cartermckinnon avatar May 14 '25 23:05 cartermckinnon

@cartermckinnon roger that! I've dispatched a workflow. 👍

github-actions[bot] avatar May 14 '25 23:05 github-actions[bot]

@cartermckinnon the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.26 / al2023success ✅skipped ⏭️
1.27 / al2023success ✅skipped ⏭️
1.28 / al2023success ✅skipped ⏭️
1.29 / al2023success ✅skipped ⏭️
1.30 / al2023failure ❌skipped ⏭️
1.31 / al2023failure ❌skipped ⏭️
1.32 / al2023failure ❌skipped ⏭️

github-actions[bot] avatar May 14 '25 23:05 github-actions[bot]

Can this be released to all AL2023 images soon, please?

GrigoryEvko avatar Jun 03 '25 01:06 GrigoryEvko

/ci build +build enable_accelerator=neuron enable_efa=true

cartermckinnon avatar Jun 03 '25 07:06 cartermckinnon

@cartermckinnon roger that! I've dispatched a workflow. 👍

github-actions[bot] avatar Jun 03 '25 07:06 github-actions[bot]

@cartermckinnon the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.26 / al2023success ✅skipped ⏭️
1.27 / al2023success ✅skipped ⏭️
1.28 / al2023success ✅skipped ⏭️
1.29 / al2023success ✅skipped ⏭️
1.30 / al2023success ✅skipped ⏭️
1.31 / al2023success ✅skipped ⏭️
1.32 / al2023success ✅skipped ⏭️
1.33 / al2023success ✅skipped ⏭️

github-actions[bot] avatar Jun 03 '25 07:06 github-actions[bot]

The neuronx kernel modules are now building successfully on 6.12 🥳

cartermckinnon avatar Jun 03 '25 08:06 cartermckinnon

Could someone merge these changes in, please? It would be great to have 6.12 kernel available.

artem-ag avatar Jul 02 '25 23:07 artem-ag

/ci build +build enable_accelerator=neuron enable_efa=true

ndbaker1 avatar Jul 02 '25 23:07 ndbaker1

@ndbaker1 roger that! I've dispatched a workflow. 👍

github-actions[bot] avatar Jul 02 '25 23:07 github-actions[bot]

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.27 / al2023success ✅skipped ⏭️
1.28 / al2023success ✅skipped ⏭️
1.29 / al2023success ✅skipped ⏭️
1.30 / al2023success ✅skipped ⏭️
1.31 / al2023success ✅skipped ⏭️
1.32 / al2023success ✅skipped ⏭️
1.33 / al2023success ✅skipped ⏭️

github-actions[bot] avatar Jul 03 '25 00:07 github-actions[bot]

Hello, seems like the PR is all green and approved. Is it possible to merge it and make 6.12 kernel available?

artem-ag avatar Jul 17 '25 17:07 artem-ag

@artem-ag we are very aware that folks are interested in the 6.12 kernel and will merge this as soon as we can

cartermckinnon avatar Jul 17 '25 17:07 cartermckinnon