amazon-eks-ami
amazon-eks-ami copied to clipboard
`bootstrap.sh` should support setting the `ecr` endpoint type (such as `ecr-fips`)
What happened:
In an environment which requires FIPS ./files/bootstrap.sh
used the standard ecr
endpoint, not ecr-fips
.
This can't be easily set in this code:
https://github.com/awslabs/amazon-eks-ami/blob/d9c8938f6666d3037d126ee906c2f133f2be0fb8/files/bootstrap.sh#L351
What you expected to happen:
Update bootstrap.sh with:
- A variable named like
$PAUSE_CONTAINER_ENDPOINT_TYPE
which defaults toecr
. - A switch of
--pause-container-endpoint-type
which can set the variable. - Update the line above to use that variable.
Environment:
- AWS Region: us-gov-west-1
- EKS Platform version: eks.10
- Kubernetes version: 1.21
Here's a PR to solve this: #1012
I believe this is now resolved with #1458 - cc @cartermckinnon
Ref: https://github.com/awslabs/amazon-eks-ami/pull/1458/files#diff-2a573fe0e1a474595da4e9944a8e3c95aead7ab627514e3fc3a6f6702768f8d1R72-R78