amazon-ecr-credential-helper icon indicating copy to clipboard operation
amazon-ecr-credential-helper copied to clipboard

Published 20 hours ago • verified publisher icon awslabs

Don't require amazonaws.com in ECR url pattern

Open jtwalraven opened this issue 2 years ago • 0 comments

Issue #, if available:

N/A

Description of changes:

Some deployments of AWS are served behind a proxy or have an alternative domain name. The current code checks for amazonaws.com in the domain name when it gets matches via the regex (see https://github.com/awslabs/amazon-ecr-credential-helper/blob/main/ecr-login/api/client.go#L40). The domain name does not appear to be used in the matches argument and could be removed to enable using this against proxy, alternative, or iso region deployments of AWS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jtwalraven avatar Jun 22 '22 22:06 jtwalraven