aws-doc-sdk-examples icon indicating copy to clipboard operation
aws-doc-sdk-examples copied to clipboard

Swift: Added video generation example code for Nova Reel, Amazon Bedrock

Open monadierickx opened this issue 6 months ago • 1 comments

This pull request includes a basic video generation code example, modeled after the python example.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

monadierickx avatar May 25 '25 08:05 monadierickx

@monadierickx can you make this tiny update ? Thank you

sebsto avatar Jun 05 '25 10:06 sebsto

Apologies for the delay, I fixed my mistake and the code should work correctly now.

monadierickx avatar Jun 16 '25 11:06 monadierickx

@shepazon code is fixed and branch is updated. Can you review again ? Thanks

sebsto avatar Jun 16 '25 12:06 sebsto

One very small nitpick. The directory name for this example uses underscores while the previously existing example in the same directory uses hyphens for word separation. Ideally these would be the same. I won't insist on changing it but I'd be delighted if it were. :)

Other than that, LGTM.

I noticed the inconsistency too. I propose to fix this in a separate PR once the open PR's are merged. As that would allow me to make all bedrock runtime code examples consistent.

If that is the way you want to go, would you prefer all hyphens, underscores or CamelCasing? The convention within the code examples was not clear to me.

monadierickx avatar Jun 17 '25 08:06 monadierickx

@brmur do you know when this will be merged ?

sebsto avatar Jun 29 '25 18:06 sebsto