aws-doc-sdk-examples icon indicating copy to clipboard operation
aws-doc-sdk-examples copied to clipboard

Bash full linting (tech debt)

Open rlhagerm opened this issue 1 year ago • 2 comments

This story is to address tech debt and failing linting after PR #5811. Complete when full linting passes.

rlhagerm avatar Jan 16 '24 17:01 rlhagerm

@meyertst-aws Can you evaluate whether changes are needed to the linter for Bash, as it may be too strict at the moment.

brmur avatar Jan 16 '24 18:01 brmur

https://github.com/awsdocs/aws-doc-sdk-examples/actions/runs/7543595843/job/20534972544

Some of these are real errors:

image

So Tools Team can go in and fix those in the .tools/.github directories.

Some of these are a pattern in the aws-cli code:

image

Which I disagree with the finding, checking two things and capturing RESPONSE in that check would be onerous. So if that's a pattern @meyertst-aws approves of and uses often, let's add SC2028 to the exclusion list in https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/aws-cli/bash-linux/.shellcheckrc (docs: https://www.shellcheck.net/wiki/Directive)

DavidSouther avatar Feb 14 '24 14:02 DavidSouther